refactor(convert-args): remove unused arguments#253
Merged
evenstensberg merged 2 commits intoJan 30, 2018
Conversation
sendilkumarn
commented
Jan 26, 2018
| var prepareOptions = require("./prepareOptions"); | ||
| module.exports = function(yargs, argv, convertOptions) { | ||
| module.exports = function(...args) { | ||
| var argv = args[1] || args[0]; |
Contributor
Author
There was a problem hiding this comment.
I dont want to change the var this needs to be handled across the cli 👍
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
shellscape
approved these changes
Jan 26, 2018
evenstensberg
requested changes
Jan 29, 2018
evenstensberg
left a comment
Member
There was a problem hiding this comment.
Can you remove yargs from bin/webpack.js L223, and bin/processOptions.js L12? Its unused anyways.
|
@sendilkumarn Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
Contributor
Author
|
@ev1stensberg Good catch 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #250