[feature] --silent#241
Merged
Merged
Conversation
- Adds --silent option for suppressing output to stdout [webpack#22]
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Member
|
Thanks! Could you remove the quiet flag and its code while at it? Cc @bebraw |
Author
|
@ev1stensberg – I'm not so sure it was ever actually implemented. I'm not seeing anything in |
Member
|
Remember adding the feature, maybe it has been discarded. I'll check and get back to you during the day |
evenstensberg
approved these changes
Jan 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--silentoption for suppressing output to stdout [Feature: Support --quiet on the command-line #22]What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes - the test is a duplicate of
test/binCases/stats/multi-config, with some modifications to try and force more output.If relevant, did you update the documentation?
webpack/webpack.js.org#1781
Summary
Related Issue: #22
This is possibly a naïve implementation, but seems to get the job done now that
webpack-cliis it's own module.Currently this change will not suppress output for the "non-compilation" commands. I can update this PR if it should, however most seem like they would not benefit from a
--silentflag.As far as the name for the actual flag, I can change that as well... @ev1stensberg previously mentioned
-s/--savewas taken at one point, but it looks open now?Does this PR introduce a breaking change?
No