Merged
Conversation
- Fix PR link to point to webpack/webpack-bundle-analyzer - Add proper GitHub profile attribution @theEquinoxDev - Follow established changelog format consistency
valscion
approved these changes
Jan 7, 2026
Member
valscion
left a comment
There was a problem hiding this comment.
Looks good, thanks! Care to add a changelog entry as well?
Contributor
Author
|
Added a changelog entry for the tooltip dark-mode fix. Thanks for the review! |
client/components/Tooltip.css
Outdated
| } | ||
|
|
||
| :global(html[data-theme='dark']) .container { | ||
| background: #1f2937; |
Member
There was a problem hiding this comment.
A little nitpick, can you make the colors variables and use those instead?
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing that out! Updated the tooltip styles to use the existing theme color variables. Let me know if you'd like any other changes.
valscion
approved these changes
Jan 7, 2026
Member
valscion
left a comment
There was a problem hiding this comment.
Yeah this would be good to go to me. I assume it works as expected.
I took the liberty to fix the entry position in changelog.
Contributor
Author
|
Great, thanks for the review and for taking care of the changelog entry. really appreciate it! Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes tooltip text and background colors in dark mode by properly scoping the global theme selector when using CSS Modules.
This change addresses the tooltip dark-mode styling issue discussed in:
#687