fix(commonjs-static): export unprovided variables#19303
Merged
alexander-akait merged 1 commit intowebpack:mainfrom Mar 11, 2025
Merged
fix(commonjs-static): export unprovided variables#19303alexander-akait merged 1 commit intowebpack:mainfrom
alexander-akait merged 1 commit intowebpack:mainfrom
Conversation
b2417e9 to
0f74789
Compare
alexander-akait
approved these changes
Mar 10, 2025
Member
alexander-akait
left a comment
There was a problem hiding this comment.
@fi3ework Can you rebase? 😄
0f74789 to
277e17b
Compare
Member
|
Ignore the other lint error, I will resolve it, thank you for your PR ⭐ |
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Previously, any unprovided export will be skipped directly, which will lost export in the following common library usage:
In this PR, I added a loop to assign exports in the way of
commonjsto ensure nothing is lost.Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
I don't think so.
What needs to be documented once your changes are merged?
No.