fix(externals): distinguish “module” and “import” in “module-import”#18790
Merged
alexander-akait merged 1 commit intowebpack:mainfrom Sep 25, 2024
Merged
fix(externals): distinguish “module” and “import” in “module-import”#18790alexander-akait merged 1 commit intowebpack:mainfrom
alexander-akait merged 1 commit intowebpack:mainfrom
Conversation
Contributor
|
For maintainers only:
|
alexander-akait
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
To reproduce: Given there's an external module
'module-a'both being imported by static-import and dynamic import, and the external type is set to'module-import'.Expected: The static import becomes
'module', while the other one is 'import'.Actual: Both external imports are either
'import'or'module'.Why: module identifier does not count in
dependencyMetawhich is used to distinguish'module'and'import'in'module-import'.Overview changes:
'module-importin_getRequestAndExternalTypeby adding_resolveExternalType. This change will help resolve both'module-import' -> 'module'&'module'and'module-import' -> 'import'&'import'to the same module, as'module-import'does not introduce a new type beyond'module'and'import'.'module-import'and the current PR.Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
No.
What needs to be documented once your changes are merged?
No.