chore(deps): no outdated strip-ansi#20835
Conversation
|
|
This PR is packaged and the instant preview is available (46042b9). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@46042b9
yarn add -D webpack@https://pkg.pr.new/webpack@46042b9
pnpm add -D webpack@https://pkg.pr.new/webpack@46042b9 |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #20835 +/- ##
==========================================
- Coverage 91.44% 91.43% -0.01%
==========================================
Files 562 562
Lines 55402 55402
Branches 14619 14619
==========================================
- Hits 50660 50656 -4
- Misses 4742 4746 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes the strip-ansi devDependency and replaces its usage in tests with a local helper that prefers Node’s built-in util.stripVTControlCharacters, falling back to a regex implementation when unavailable.
Changes:
- Added
test/helpers/stripVTControlCharacters.jsto strip VT/ANSI control characters usingutil.stripVTControlCharacterswith a regex fallback. - Updated test helpers/tests to use the new local stripping helper instead of
strip-ansi. - Removed
strip-ansifrompackage.jsonand removed its Dependabot exclusion entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/helpers/stripVTControlCharacters.js | New helper that strips VT control sequences using Node util when available, otherwise regex. |
| test/helpers/captureStdio.js | Switches stripping implementation from strip-ansi to the new local helper. |
| test/Defaults.unittest.js | Switches stripping implementation from strip-ansi to the new local helper. |
| package.json | Removes strip-ansi from devDependencies. |
| .github/dependabot.yml | Removes the strip-ansi exclusion entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merging this PR will degrade performance by 25.28%
Performance Changes
Comparing 
|
Summary
avoid outdated deps and use built-in method
What kind of change does this PR introduce?
refactor and chore
Did you add tests for your changes?
No need
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing
Use of AI
No