You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ModuleChunkLoadingRuntimeModule enables prefetch/preload handlers for neutral platform targets (target: ["web", "node"]) via the isNeutralPlatform flag, and injects a typeof document === 'undefined' guard so they return early in Node environments. This code path had no test coverage.
This PR adds a configCase that compiles an ESM entry with webpackPrefetch/webpackPreload magic comments under target: ["web", "node"] and verifies:
web variant: prefetch (rel="prefetch") and preload (rel="modulepreload") links are correctly appended to document.head
node variant: handlers return early without crashing when document is not defined
What kind of change does this PR introduce?
test
Did you add tests for your changes?
This PR is the test. It adds test/configCases/target/universal-prefetch-preload/.
Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModuleChunkLoadingRuntimeModuleenables prefetch/preload handlers for neutral platform targets (target: ["web", "node"]) via theisNeutralPlatformflag, and injects atypeof document === 'undefined'guard so they return early in Node environments. This code path had no test coverage.This PR adds a configCase that compiles an ESM entry with
webpackPrefetch/webpackPreloadmagic comments undertarget: ["web", "node"]and verifies:rel="prefetch") and preload (rel="modulepreload") links are correctly appended todocument.headdocumentis not definedWhat kind of change does this PR introduce?
test
Did you add tests for your changes?
This PR is the test. It adds
test/configCases/target/universal-prefetch-preload/.Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No documentation needed