Skip to content

test: add self-import test case for dynamic import#20389

Merged
alexander-akait merged 1 commit intomainfrom
import
Jan 30, 2026
Merged

test: add self-import test case for dynamic import#20389
alexander-akait merged 1 commit intomainfrom
import

Conversation

@xiaoxiaojx
Copy link
Member

Summary
test: add self-import test case for dynamic import

What kind of change does this PR introduce?
test

Did you add tests for your changes?
Yes

Does this PR introduce a breaking change?
No

If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2026

⚠️ No Changeset found

Latest commit: ca6115c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

This PR is packaged and the instant preview is available (a656ab1).

Install it locally:

  • npm
npm i -D webpack@https://pkg.pr.new/webpack@a656ab1
  • yarn
yarn add -D webpack@https://pkg.pr.new/webpack@a656ab1
  • pnpm
pnpm add -D webpack@https://pkg.pr.new/webpack@a656ab1

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 30, 2026

Merging this PR will not alter performance

✅ 72 untouched benchmarks


Comparing import (ca6115c) with main (8056413)

Open in CodSpeed

/Critical dependency: the request of a dependency is an expression/,
/Critical dependency: the request of a dependency is an expression/,
/Critical dependency: the request of a dependency is an expression/,
/Critical dependency: the request of a dependency is an expression/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can avoid this message in such simple cases, but not sure, let's merge and think about it later

@alexander-akait alexander-akait merged commit a656ab1 into main Jan 30, 2026
89 of 92 checks passed
@alexander-akait alexander-akait deleted the import branch January 30, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants