Skip to content

test: no runtime requirements for module library #20127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexander-akait merged 3 commits into from
Nov 17, 2025
Merged

test: no runtime requirements for module library #20127

alexander-akait merged 3 commits into from
Nov 17, 2025

Conversation

@hai-x
Copy link
Member

@hai-x hai-x commented Nov 16, 2025 •
edited
Loading

Summary

What kind of change does this PR introduce?

Add test for #20096.

I add 3 cases and hopefully it is enough to illustrate the above refactor. Also feel free to request more test cases.

  1. entry module isn't inlined.
  2. entry module is inlined and wrapped in IIFE.
  3. entry module is inlined but not wrapped in IIFE.

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

If relevant, what needs to be documented once your changes are merged or what have you already documented?

No

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2025 •
edited
Loading 

        This PR is packaged and the instant preview is available (https://github.com/webpack/webpack/commit/688a7f951143ea5c9fddb59380e9fd8754e5ef89).

        Install it locally:

        - npm

        ```shell
        npm i -D webpack@https://pkg.pr.new/webpack@688a7f9
        ```

        - yarn

        ```shell
        yarn add -D webpack@https://pkg.pr.new/webpack@688a7f9
        ```

        - pnpm

        ```shell
        pnpm add -D webpack@https://pkg.pr.new/webpack@688a7f9
        ```

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 16, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #20127 will not alter performance

Comparing test--no-runtime-requirements-for-module-library (61362bc) with main (04fe5a1)

Summary

✅ 69 untouched

@alexander-akait
Copy link
Member

alexander-akait commented Nov 17, 2025

@hai-x Let's exclude node@10 for tests here

@alexander-akait alexander-akait merged commit 688a7f9 into main Nov 17, 2025
91 of 92 checks passed
@alexander-akait alexander-akait deleted the test--no-runtime-requirements-for-module-library branch November 17, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hai-x @alexander-akait