fix: keep module traversal consistent across reexport scenarios#19702
Merged
alexander-akait merged 1 commit intomainfrom Jul 15, 2025
Merged
fix: keep module traversal consistent across reexport scenarios#19702alexander-akait merged 1 commit intomainfrom
alexander-akait merged 1 commit intomainfrom
Conversation
CodSpeed Performance ReportMerging #19702 will degrade performances by 21.61%Comparing Summary
Benchmarks breakdown
|
alexander-akait
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #19686
keep the import order of dependency and dependency2 in the reexport within component.js
input
output
// output /***/ "./component.js": /*!**********************!*\ !*** ./component.js ***! \**********************/ /***/ ((__unused_webpack_module, __webpack_exports__, __webpack_require__) => { __webpack_require__.r(__webpack_exports__); /* harmony export */ __webpack_require__.d(__webpack_exports__, { /* harmony export */ component: () => (/* binding */ component), /* harmony export */ dependency: () => (/* reexport safe */ _dependency__WEBPACK_IMPORTED_MODULE_1__.dependency), /* harmony export */ dependency2: () => (/* reexport safe */ _dependency__WEBPACK_IMPORTED_MODULE_0__.dependency2) /* harmony export */ }); + /* harmony import */ var _dependency__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! ./dependency */ "./dependency/dependency2.js"); + /* harmony import */ var _dependency__WEBPACK_IMPORTED_MODULE_1__ = __webpack_require__(/*! ./dependency */ "./dependency/dependency.js"); - /* harmony import */ var _dependency__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! ./dependency */ "./dependency/dependency.js"); - /* harmony import */ var _dependency__WEBPACK_IMPORTED_MODULE_1__ = __webpack_require__(/*! ./dependency */ "./dependency/dependency2.js"); function component(...args) { console.log(args); }Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
No