test: hotCaseTest and watchCaseTest no longer auto setup jsdom env#19676
Merged
alexander-akait merged 1 commit intomainfrom Jul 9, 2025
Merged
test: hotCaseTest and watchCaseTest no longer auto setup jsdom env#19676alexander-akait merged 1 commit intomainfrom
alexander-akait merged 1 commit intomainfrom
Conversation
Member
|
Technically fetch exists in Node.js - https://nodejs.org/en/learn/getting-started/fetch, but should throw an error when |
CodSpeed Performance ReportMerging #19676 will degrade performances by 94.28%Comparing Summary
Benchmarks breakdown
|
alexander-akait
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
We should not setup jsdom (i.e. fetch...) when
target: node.Did you add tests for your changes?
Existing
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
No