Skip to content

fix: lose closing brace when exports are unprovided#19669

Merged
alexander-akait merged 1 commit intomainfrom
fix-19664
Jul 8, 2025
Merged

fix: lose closing brace when exports are unprovided#19669
alexander-akait merged 1 commit intomainfrom
fix-19664

Conversation

@hai-x
Copy link
Member

@hai-x hai-x commented Jul 8, 2025

What kind of change does this PR introduce?

Fixes #19664.

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 8, 2025

CodSpeed Performance Report

Merging #19669 will improve performances by ×5.8

Comparing fix-19664 (e76898d) with main (260f85e)

Summary

⚡ 85 improvements
✅ 48 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 37.4 ms 13.8 ms ×2.7
benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 49.3 ms 11.4 ms ×4.3
benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 33.5 ms 11.6 ms ×2.9
benchmark "many-chunks-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 61.4 ms 10.5 ms ×5.8
benchmark "many-chunks-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 61.8 ms 11.2 ms ×5.5
benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 64.8 ms 52.1 ms +24.34%
md4 buffer benchmark (size: 10000) 114.2 µs 73 µs +56.5%
md4 buffer benchmark (size: 100000) 447.9 µs 406.5 µs +10.19%
md4 buffer benchmark (size: 120) 76.2 µs 34.8 µs ×2.2
md4 buffer benchmark (size: 160) 76.1 µs 34.9 µs ×2.2
md4 buffer benchmark (size: 16366) 138.5 µs 97.3 µs +42.27%
md4 buffer benchmark (size: 16368) 138.6 µs 97.3 µs +42.38%
md4 buffer benchmark (size: 16370) 138.7 µs 97.3 µs +42.47%
md4 buffer benchmark (size: 2) 76.3 µs 34.9 µs ×2.2
md4 buffer benchmark (size: 20) 76.2 µs 32.5 µs ×2.3
md4 buffer benchmark (size: 200) 76.4 µs 35.1 µs ×2.2
md4 buffer benchmark (size: 2000) 82 µs 40.8 µs ×2
md4 buffer benchmark (size: 20000) 152.7 µs 111.5 µs +37.02%
md4 buffer benchmark (size: 2002) 82 µs 40.7 µs ×2
md4 buffer benchmark (size: 40) 73.6 µs 32.4 µs ×2.3
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@alexander-akait alexander-akait merged commit 6801022 into main Jul 8, 2025
44 checks passed
@alexander-akait alexander-akait deleted the fix-19664 branch July 8, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syntactically invalid bundle generated for commonjs-static when using ts-loader

2 participants