fix(TsconfigPathsPlugin): gracefully handle missing tsconfig.json#502
fix(TsconfigPathsPlugin): gracefully handle missing tsconfig.json#502alexander-akait merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: d198a3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
==========================================
- Coverage 93.43% 93.42% -0.02%
==========================================
Files 50 50
Lines 2515 2524 +9
Branches 767 773 +6
==========================================
+ Hits 2350 2358 +8
- Misses 136 137 +1
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| extensions: [".ts", ".tsx"], | ||
| mainFields: ["browser", "main"], | ||
| mainFiles: ["index"], | ||
| tsconfig: path.join(noTsconfigDir, "tsconfig.json"), |
There was a problem hiding this comment.
I think in such case we should throw an error, we should not throw an error when tsconfig is just a true
1bdb490 to
86e3b8e
Compare
Summary
fix(TsconfigPathsPlugin): gracefully handle missing tsconfig.json
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing