fix(TsconfigPathsPlugin): give references priority over main paths#552
Merged
alexander-akait merged 3 commits intomainfrom Apr 22, 2026
Merged
Conversation
When the main tsconfig defines an alias that is also declared by a referenced project, the reference's mapping should win. Previously `_selectPathsDataForContext` returned only the main context's own paths for requests against the main context, so referenced aliases were never consulted in the conflict case. Now, when refs exist, the main context's alias list is materialised as `[...refAliases, ...mainOwnAliases]`. `forEachBail` in `aliasResolveHandler` therefore checks references first and only falls back to main paths when no reference alias matches. Modules (baseUrl candidates) stay scoped to each context so per-reference baseUrl resolution is unaffected.
…paths" This reverts commit e1a9244.
Adds a conflict fixture where main and a referenced project both declare "@lib/*" but point at different targets. The new tests assert: - Resolving @lib/foo from the main context uses main's target. - Resolving @lib/foo from the reference's directory uses the reference's target. - The reference's target does not leak into main-context lookups. This matches how tsc resolves paths — strictly through the tsconfig that owns the importing file, with no merging across a references edge.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
==========================================
+ Coverage 96.57% 96.60% +0.03%
==========================================
Files 50 50
Lines 2800 2800
Branches 863 863
==========================================
+ Hits 2704 2705 +1
+ Misses 80 79 -1
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the main tsconfig defines an alias that is also declared by a
referenced project, the reference's mapping should win. Previously
_selectPathsDataForContextreturned only the main context's ownpaths for requests against the main context, so referenced aliases
were never consulted in the conflict case.
Now, when refs exist, the main context's alias list is materialised
as
[...refAliases, ...mainOwnAliases].forEachBailinaliasResolveHandlertherefore checks references first and onlyfalls back to main paths when no reference alias matches. Modules
(baseUrl candidates) stay scoped to each context so per-reference
baseUrl resolution is unaffected.