feat: support spawnOpts for geckodriver child process#552
Conversation
christian-bromann
left a comment
There was a problem hiding this comment.
Can we document the new user parameter? Maybe including an example as well?
893750d to
ec9e561
Compare
christian-bromann
left a comment
There was a problem hiding this comment.
Great stuff, LGTM 👍
awesome I will get the docs updated then we should be good to go! |
|
docs updated @christian-bromann . Thank you for the really fast review on this! |
|
Hey AtofStryker 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
I am currently migrating Cypress to use
webdriverandgeckodriverfor our firefox automation. We have the needs to propagate some environment variables to the geckodriver process (better outlined in this bugzilla comment), which we are patching this package to accomplish now. This PR is to move this patch upstream as a contribution.In order to propagate environment variables to the firefox process started with
geckodriver, the environment variables need to be passed to thegeckodriverprocess directly in order to be passed tofirefox. This is important for settingMOZ_prefixed variables, likeMOZ_HEADLESS_HEIGHTorMOZ_HEADLESS_WIDTH. This PR allows spawn options to be passed into the geckodriver process.