Skip to content

Fix/bidi cookie robustness#15034

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
mccmrunal:fix/bidi-cookie-robustness
Jan 23, 2026
Merged

Fix/bidi cookie robustness#15034
christian-bromann merged 2 commits intowebdriverio:mainfrom
mccmrunal:fix/bidi-cookie-robustness

Conversation

@mccmrunal
Copy link
Contributor

@mccmrunal mccmrunal commented Jan 19, 2026 •
edited
Loading

Proposed changes

Issue #15033
//: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.)
Fixes stability and scoping issues for cookie commands in WebDriver BiDi by correctly scoping cookies to the current page origin, adding a robust fallback to Classic WebDriver when BiDi is unreliable, ensuring cookies are actually deleted, and improving UTF-8 handling for cookie values.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@mccmrunal
Copy link
Contributor Author

mccmrunal commented Jan 19, 2026

image Ran across multiple scenarios works good now!

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 19, 2026 •
edited
Loading

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@15034

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@15034

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@15034

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@15034

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@15034

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@15034

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@15034

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@15034

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@15034

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@15034

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@15034

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@15034

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@15034

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@15034

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@15034

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@15034

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@15034

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@15034

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@15034

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@15034

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@15034

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@15034

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@15034

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@15034

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@15034

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@15034

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@15034

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@15034

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@15034

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@15034

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@15034

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@15034

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@15034

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@15034

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@15034

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@15034

@wdio/xvfb

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/xvfb@15034

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@15034

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@15034

commit: 0a7b3ce

@mccmrunal mccmrunal force-pushed the fix/bidi-cookie-robustness branch from 455a802 to 0a7b3ce Compare January 20, 2026 18:35
@mccmrunal mccmrunal closed this Jan 20, 2026
@mccmrunal mccmrunal reopened this Jan 20, 2026
@mccmrunal mccmrunal closed this Jan 20, 2026
@mccmrunal mccmrunal reopened this Jan 20, 2026
christian-bromann
christian-bromann approved these changes Jan 23, 2026
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 23, 2026
@christian-bromann christian-bromann merged commit 4db63f4 into webdriverio:main Jan 23, 2026
107 of 113 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Jan 23, 2026

Hey mccmrunal 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $35 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mccmrunal @wdio-bot @christian-bromann