fix: remove double ports for start-appium-inspector#14961
Merged
christian-bromann merged 2 commits intomainfrom Jan 8, 2026
Merged
fix: remove double ports for start-appium-inspector#14961christian-bromann merged 2 commits intomainfrom
start-appium-inspector#14961christian-bromann merged 2 commits intomainfrom
Conversation
3 tasks
create-wdio
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
@wdio/xvfb
webdriver
webdriverio
commit: |
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #14960 by preventing duplicate port arguments from being passed to the Appium Inspector. The fix ensures that when users provide a port via command-line arguments, it doesn't get duplicated when the CLI sets up the Appium server arguments.
Key Changes:
- Added
removePortFromArgsfunction to remove existing port arguments from the args array before adding the normalized port - Modified
cli.tsto remove any existing port arguments and then add the extracted/default port at the beginning of the args array - Added comprehensive unit tests for the new
removePortFromArgsfunction
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/wdio-appium-service/src/cli-utils.ts | Adds removePortFromArgs function to handle removal of port arguments in both --port=value and --port value formats |
| packages/wdio-appium-service/src/cli.ts | Integrates removePortFromArgs to clean up existing port arguments before adding the normalized port value |
| packages/wdio-appium-service/tests/cli-utils.test.ts | Adds comprehensive test coverage for removePortFromArgs including edge cases like empty arrays and multiple port arguments in mixed formats |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This fixes #14960, we passed multiple ports to the
appium-inspectorwhich caused extra noiseTypes of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers