Merged
Conversation
erwinheitzman
approved these changes
Sep 6, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds error handling to prevent isStable and waitForStable commands from being executed in native mobile app contexts, where they are not supported. The change ensures these commands throw clear error messages when used inappropriately.
- Added native context validation to both
isStableandwaitForStablecommands - Updated documentation to clarify browser-only availability
- Added comprehensive tests to verify error handling for native contexts
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/webdriverio/src/commands/element/isStable.ts | Added native context check and updated documentation |
| packages/webdriverio/src/commands/element/waitForStable.ts | Added native context check and updated documentation |
| packages/webdriverio/tests/commands/element/isStable.test.ts | Added test case for native context error handling |
| packages/webdriverio/tests/commands/element/waitForStable.test.ts | Added test case for native context error handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change will make sure it throws an error for native apps
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers