fix(attach-params): user options should override detectBackend#14714
fix(attach-params): user options should override detectBackend#14714christian-bromann merged 3 commits intowebdriverio:mainfrom
Conversation
|
Options passed to the user‑side attach API are being dropped in detectBackend because it overrides the user options. This PR is necessary to preserve the user’s options—I’d appreciate a merge. 🙏 |
christian-bromann
left a comment
There was a problem hiding this comment.
Can we add a unit test for this to ensure we don't regress here?
|
That’s a really good idea, and I added a test where it initially fails but succeeds after making corrections.
|
|
Hey NaamuKim 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
|
When is this released? |
Proposed changes
user options should override detectBackend in
attachisn't it?
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers