fix: avoid starting a timeout if the timer was resolved immediately#14642
Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom Jul 14, 2025
Merged
Conversation
The committers listed above are authorized under a signed CLA. |
Contributor
|
Hey sheremet-va 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
There is a small bug in the timer implementation. If the timer is
leading, it can resolve the timer immediately. When it does this, it clears the_timeoutIdand_mainTimeoutId, but since if was resolved immediately, the_mainTimeoutIdis not created yet.So, the timeout resolves and always creates a 5 seconds timer which hangs the process. This is especially visible when
browser.deleteSessionis called.I debugged this using the same reproduction from #14639, but called
destroySessionat the end. I expect the process to stop immediately after the promise is resolved, but I always need to wait 5 seconds because theurlmethod started a timeout, but never cleared it.Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers