fix(@wdio/jasmine-framework): become independant from expect-webdriverio#14592
Merged
christian-bromann merged 16 commits intomainfrom Jul 8, 2025
Merged
fix(@wdio/jasmine-framework): become independant from expect-webdriverio#14592christian-bromann merged 16 commits intomainfrom
christian-bromann merged 16 commits intomainfrom
Conversation
15 tasks
7b5c1af to
aaaea24
Compare
dprevost-LMI
reviewed
Jul 1, 2025
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
This was referenced Jul 1, 2025
8bd97b8 to
84f8a76
Compare
dprevost-LMI
reviewed
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
With changes we made in
expect-webdriverio, e.g. adding soft assertions as well as snapshot tests, we require framework packages to import the sameexpect-webdriveriomodule as the@wdio/runnerpackage to ensure both features work. For Mocha and Cucumber this is less of a problem, as we set everything up in the runner. However in Jasmine, we enhance the provided expect-library with WDIO matchers which requires us to have access to the module within the framework package.Before this wasn't an issue but now we are seeing builds breaking as both packages import different versions of
expect-webdriverio. In this patch we make a slight logic change to have the@wdio/runnerpackage pass along theexpect-webdriverioprimitives to guarantee only one package version is used.It is unclear if this is an issue that WebdriverIO users are ever facing. That said, we have now run into issues in our builds.
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
n/a
Reviewers: @webdriverio/project-committers