Skip to content

Fix for isAndroid outside of test#14572

Merged
christian-bromann merged 4 commits intowebdriverio:mainfrom
AakashHotchandani:isAndroidFix
Jun 19, 2025
Merged

Fix for isAndroid outside of test#14572
christian-bromann merged 4 commits intowebdriverio:mainfrom
AakashHotchandani:isAndroidFix

Conversation

@AakashHotchandani
Copy link
Contributor

@AakashHotchandani AakashHotchandani commented Jun 18, 2025 •
edited
Loading

Proposed changes

The change maintains backward compatibility while extending detection to handle BrowserStack's device naming patterns. This should resolve the inconsistency mentioned in the GitHub issue where isAndroid behaved differently before and after session creation.

ref: #14529 (comment)

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 18, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@christian-bromann
Copy link
Member

christian-bromann commented Jun 18, 2025

@AakashHotchandani Thanks for the contributions, mind signing the CLA?

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 19, 2025 •
edited
Loading

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14572

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14572

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14572

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14572

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14572

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14572

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14572

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14572

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14572

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14572

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14572

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14572

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14572

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14572

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14572

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14572

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14572

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14572

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14572

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14572

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14572

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14572

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14572

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14572

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14572

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14572

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14572

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14572

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14572

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14572

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14572

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14572

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14572

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14572

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14572

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14572

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14572

commit: f76c577

@AakashHotchandani
Copy link
Contributor Author

AakashHotchandani commented Jun 19, 2025 •
edited
Loading

@christian-bromann The tests on macos-13 and windows-latest failed, but they don't seem related to my changes. Is that expected?

@christian-bromann
Copy link
Member

christian-bromann commented Jun 19, 2025

Is that expected?

Yes, I am still up to fix them in main. Will go ahead and merge.

christian-bromann
christian-bromann approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jun 19, 2025
@christian-bromann christian-bromann merged commit 2d71b09 into webdriverio:main Jun 19, 2025
41 of 43 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Jun 19, 2025

Hey AakashHotchandani 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AakashHotchandani @christian-bromann @wdio-bot