Skip to content

fix(wdio-utils):fix to support windows path string #14565

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
mato533:fix/abs-path
Jun 16, 2025
Merged

fix(wdio-utils):fix to support windows path string #14565
christian-bromann merged 2 commits intowebdriverio:mainfrom
mato533:fix/abs-path

Conversation

@mato533
Copy link
Member

@mato533 mato533 commented Jun 13, 2025

Proposed changes

Modify isAbsolute function so that initializePlugin can import using absolute paths of the Windows platform.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

Closes #14532

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 13, 2025 •
edited
Loading

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14565

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14565

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14565

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14565

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14565

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14565

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14565

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14565

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14565

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14565

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14565

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14565

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14565

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14565

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14565

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14565

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14565

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14565

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14565

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14565

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14565

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14565

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14565

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14565

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14565

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14565

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14565

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14565

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14565

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14565

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14565

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14565

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14565

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14565

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14565

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14565

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14565

commit: a02cc27

@mato533 mato533 marked this pull request as draft June 13, 2025 07:58
@mato533 mato533 marked this pull request as draft June 13, 2025 07:58
@mato533 mato533 marked this pull request as ready for review June 13, 2025 08:18
@mato533
Copy link
Member Author

mato533 commented Jun 13, 2025

Failure of Component Tests might not be related this changes. (may be related #14546 ?)

christian-bromann
christian-bromann reviewed Jun 13, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the services located within the @saucelabs directory? Should they be in __mocks__?

Regarding the issues in the component tests, I am investigating that.

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jun 13, 2025
@mato533
Copy link
Member Author

mato533 commented Jun 13, 2025

Why are the services located within the @saucelabs directory? Should they be in __mocks__?

You are absolutely right, I will try to sort out the MOCK part!

@mato533
Copy link
Member Author

mato533 commented Jun 15, 2025

hi, @christian-bromann
I have update unittest for the intializePlugin.

The major change was to place dummy modules in fixtures under the utils package and use them for testing.
We also changed the focus of our testing to ensure that the module is imported with a module name that matches the parameters of the responsibility under test.

christian-bromann
christian-bromann approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 👍

@christian-bromann
Copy link
Member

christian-bromann commented Jun 16, 2025

I will look into the component test issues today and will make it release once resolved.

@christian-bromann christian-bromann merged commit ac73e26 into webdriverio:main Jun 16, 2025
35 of 38 checks passed
@mato533 mato533 deleted the fix/abs-path branch June 17, 2025 10:16
@mato533 mato533 mentioned this pull request Jun 29, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Failed to import custom reporter module

2 participants

@mato533 @christian-bromann