feat(wdio-runner): automatically include SoftAssertionService#14546
Conversation
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
christian-bromann
left a comment
There was a problem hiding this comment.
Minor updates but overall 👍 LGTM
|
@JustasMonkev in order to get the unit tests pass we have to extend the mock for it we use across all unit tests: https://github.com/webdriverio/webdriverio/blob/main/__mocks__/expect-webdriverio.ts |
@christian-bromann I will check it today, and try to fix it |
|
@JustasMonkev I wonder if these snapshot issues are related to an updated to the |
probably checking it, rigth now |
|
I think the issue is related to this: vitest-dev/vitest#7322 |
|
Let's just adjust the snapshot for now and move on. At some point I would love to replace the jest expect library with the Vitest one. |
I commented out the failing part. When running the snapshot test, it passes, but it doesn't start the other tests it just exits after the first run is completed. |
I think because of this ☝️ |
same is also in main branch 😄 |
christian-bromann
left a comment
There was a problem hiding this comment.
LGTM 👍
I will fix the e2e test issue on main.
|
Hey JustasMonkev 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
…verio#14546) * feat: automatically include SoftAssertionService in the core * fix(docs): clarify default inclusion of SoftAssertionService in documentation * feat: add autoAssertOnTestEnd option to control soft assertion behavior * Update website/docs/Configuration.md * Update website/docs/Assertion.md * refactor(docs): reorganize Soft Assertions section for clarity * feat: add SoftAssertionService to expect-webdriverio mock * fix(tests): adjust snapshot formatting for consistency in React component tests --------- Co-authored-by: Christian Bromann <git@bromann.dev>
|
Hi, when can we expect this to be published in NPM? |
|
We've just published |
Proposed changes
This change integrates the SoftAssertionService from expect-webdriverio
directly into the wdio-runner package, making soft assertions available
to all WebdriverIO users without requiring manual configuration.
Users can now use expect.soft() to collect assertion failures without
halting test execution, improving the testing experience by providing
more comprehensive test reports.
With minimal performance impact, adding this feature by default eliminates
an unnecessary configuration step and reduces potential setup errors.
Related to: webdriverio/expect-webdriverio#1836
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers