Skip to content

fix(@wdio/protocols): Have options of appium terminateApp command optional #14522

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
dprevost-LMI:bug/issue-14521-fix-terminateApp-breaking-changes
Jun 2, 2025
Merged

fix(@wdio/protocols): Have options of appium terminateApp command optional #14522
christian-bromann merged 1 commit intowebdriverio:mainfrom
dprevost-LMI:bug/issue-14521-fix-terminateApp-breaking-changes

Conversation

@dprevost-LMI
Copy link
Contributor

@dprevost-LMI dprevost-LMI commented May 31, 2025 •
edited
Loading

Proposed changes

Since this PR, terminateApp requires passing an options args which should be optional. The missing require:false was making the arguments mandatory.

image

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Additionally, we could fix the generator here to make it optional when required is not found.

Potentially changing:

                    return `${camelCase(p.name)}${p.required === false ? '?' : ''}: ${paramType}`

by

                    return `${camelCase(p.name)}${p.required !== true ? '?' : ''}: ${paramType}`

If accepted, I can add it to this PR

Reviewers: @webdriverio/project-committers

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 31, 2025

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14522

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14522

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14522

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14522

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14522

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14522

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14522

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14522

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14522

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14522

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14522

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14522

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14522

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14522

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14522

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14522

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14522

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14522

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14522

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14522

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14522

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14522

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14522

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14522

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14522

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14522

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14522

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14522

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14522

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14522

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14522

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14522

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14522

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14522

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14522

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14522

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14522

commit: 5582a59

@dprevost-LMI dprevost-LMI marked this pull request as ready for review May 31, 2025 13:31
@dprevost-LMI dprevost-LMI changed the title bug(@wdio/protocol): Have options of appium terminateApp command optional fix(@wdio/protocols): Have options of appium terminateApp command optional May 31, 2025
@dprevost-LMI dprevost-LMI mentioned this pull request May 31, 2025
Closed
3 tasks
christian-bromann
christian-bromann approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann
Copy link
Member

christian-bromann commented Jun 2, 2025

Additionally, we could fix the generator here to make it optional when required is not found.

I think is a great idea!

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jun 2, 2025
@christian-bromann christian-bromann merged commit 405284e into webdriverio:main Jun 2, 2025
43 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Jun 2, 2025

Hey dprevost-LMI 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@dprevost-LMI
Copy link
Contributor Author

dprevost-LMI commented Jun 2, 2025

Additionally, we could fix the generator here to make it optional when required is not found.

I think is a great idea!

Cool, I'll open another PR then in the next few days!

@dprevost-LMI dprevost-LMI mentioned this pull request Jun 2, 2025
Merged
13 tasks
@dprevost-LMI dprevost-LMI deleted the bug/issue-14521-fix-terminateApp-breaking-changes branch June 8, 2025 13:18
@yashuatla yashuatla mentioned this pull request Jun 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $15 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dprevost-LMI @christian-bromann @wdio-bot