Skip to content

fix(mocha-framework): report spec load error as failure in after hook#14506

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
lezram:patch-1
Jun 25, 2025
Merged

fix(mocha-framework): report spec load error as failure in after hook#14506
christian-bromann merged 2 commits intowebdriverio:mainfrom
lezram:patch-1

Conversation

@lezram
Copy link
Contributor

@lezram lezram commented May 24, 2025 •
edited
Loading

Proposed changes

The after hook does not receive the specLoadError, therefore custom reporters using the after hook do not get the correct status. Passing the specLoadError as well to the hook to reflect the correct result, as error is thrown afterwards.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 24, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

christian-bromann
christian-bromann requested changes May 25, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this PR!

Can we create some unit tests around this section ensuring we verify this behavior? We have already some very similar tests that can enhanced or new ones added with similar code.

@lezram
Copy link
Contributor Author

lezram commented Jun 1, 2025

Thanks for raising this PR!

Can we create some unit tests around this section ensuring we verify this behavior? We have already some very similar tests that can enhanced or new ones added with similar code.

Added a separate test now,
it could also be considered to just extend the existing test case should throw runtime error if spec could not be loaded.
IMO separate case makes it easier to understand the fix / 'requirement'.

@lezram lezram requested a review from christian-bromann June 1, 2025 12:35
christian-bromann
christian-bromann approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 2, 2025

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14506

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14506

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14506

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14506

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14506

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14506

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14506

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14506

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14506

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14506

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14506

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14506

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14506

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14506

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14506

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14506

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14506

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14506

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14506

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14506

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14506

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14506

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14506

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14506

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14506

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14506

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14506

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14506

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14506

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14506

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14506

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14506

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14506

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14506

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14506

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14506

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14506

commit: 3c91bd4

@christian-bromann christian-bromann merged commit b321474 into webdriverio:main Jun 25, 2025
43 checks passed
@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jun 25, 2025
@wdio-bot
Copy link
Contributor

wdio-bot commented Jun 25, 2025

Hey lezram 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
⚠️ You seemed to have committed using an email address ending up with @users.noreply.github.com, if you don't receive the email please feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@lezram lezram deleted the patch-1 branch September 3, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lezram @wdio-bot @christian-bromann