Skip to content

add browserstack camera-image-injection to wdio-types capabilities#14474

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
DoreyKiss:add-camera-image-injection-to-bs-caps
May 14, 2025
Merged

add browserstack camera-image-injection to wdio-types capabilities#14474
christian-bromann merged 2 commits intowebdriverio:mainfrom
DoreyKiss:add-camera-image-injection-to-bs-caps

Conversation

@DoreyKiss
Copy link
Contributor

@DoreyKiss DoreyKiss commented May 13, 2025 •
edited
Loading

Proposed changes

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 13, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@christian-bromann
Copy link
Member

christian-bromann commented May 14, 2025

Thanks for raising the PR, let me know what needs to be done to move this into "Ready for review"

@DoreyKiss
Copy link
Contributor Author

DoreyKiss commented May 14, 2025

Hi,

Thanks for the quick response. I believe the PR is ready, but since this is my first contribution to the project, I’m still going through the how-to articles. I’d really appreciate any guidance or suggestions you might have.

@DoreyKiss DoreyKiss marked this pull request as ready for review May 14, 2025 17:53
christian-bromann
christian-bromann approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label May 14, 2025
@christian-bromann christian-bromann merged commit 7a4a6ce into webdriverio:main May 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DoreyKiss @christian-bromann