Skip to content

feat(reporter): add browserName function and use where required#14454

Merged
christian-bromann merged 8 commits intowebdriverio:mainfrom
Delta456:browsername
May 6, 2025
Merged

feat(reporter): add browserName function and use where required#14454
christian-bromann merged 8 commits intowebdriverio:mainfrom
Delta456:browsername

Conversation

@Delta456
Copy link
Contributor

@Delta456 Delta456 commented May 5, 2025

Proposed changes

Provide a way to get browser or app name based on the passed capabilities and allow other reporters to use it

Closes #14446

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 5, 2025 •
edited
Loading

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14454

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14454

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14454

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14454

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14454

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14454

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14454

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14454

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14454

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14454

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14454

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14454

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14454

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14454

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14454

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14454

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14454

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14454

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14454

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14454

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14454

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14454

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14454

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14454

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14454

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14454

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14454

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14454

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14454

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14454

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14454

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14454

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14454

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14454

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14454

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14454

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14454

commit: c4f26c0

christian-bromann
christian-bromann reviewed May 5, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we apply this function in the other reporter in this repository? I am sure there are some opportunities where we can replace some custom logic.

@Delta456
Copy link
Contributor Author

Delta456 commented May 5, 2025

Can we apply this function in the other reporter in this repository? I am sure there are some opportunities where we can replace some custom logic.

It should be done as discussed

@Delta456 Delta456 requested a review from christian-bromann May 5, 2025 16:24
christian-bromann
christian-bromann requested changes May 5, 2025
View reviewed changes
Delta456 and others added 3 commits May 5, 2025 22:04
@Delta456 @christian-bromann
Apply suggestions from code review
2ec3f55 
Co-authored-by: Christian Bromann <git@bromann.dev>
@Delta456
fix
3775d4e
@Delta456
remove unused import
7e5e463
@Delta456 Delta456 requested a review from christian-bromann May 6, 2025 08:47
christian-bromann
christian-bromann approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label May 6, 2025
@christian-bromann christian-bromann merged commit 7e6a5d2 into webdriverio:main May 6, 2025
8 checks passed
@Delta456 Delta456 deleted the browsername branch May 6, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[💡 Feature]: Move browser name or the mobile app from @wdio/spec-reporter to @wdio/reporter

2 participants

@Delta456 @christian-bromann