Skip to content

fix(bidi-dialog): only accept dialogs in active browsing context#14448

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
Rondleysg:main
May 3, 2025
Merged

fix(bidi-dialog): only accept dialogs in active browsing context#14448
christian-bromann merged 2 commits intowebdriverio:mainfrom
Rondleysg:main

Conversation

@Rondleysg
Copy link
Member

@Rondleysg Rondleysg commented May 2, 2025

Proposed changes

This PR adds a context check in the accept() handler so that we only call dialog.accept() when the dialog actually belongs to the current browsing context. It uses the ContextManager.getCurrentContext() helper and bails out early if this.#context !== context, preventing “no such frame” errors when multiple contexts fire native‐dialog events.

Related issue

Closes #14295

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 2, 2025 •
edited
Loading

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14448

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14448

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14448

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14448

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14448

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14448

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14448

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14448

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14448

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14448

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14448

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14448

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14448

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14448

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14448

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14448

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14448

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14448

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14448

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14448

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14448

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14448

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14448

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14448

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14448

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14448

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14448

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14448

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14448

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14448

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14448

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14448

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14448

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14448

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14448

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14448

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14448

commit: 42960d1

christian-bromann
christian-bromann requested changes May 2, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test for this?

@erwinheitzman
Copy link
Member

erwinheitzman commented May 3, 2025

Quick question, shouldn't we add this check to all public methods, like close() etc as well?

@erwinheitzman
Copy link
Member

erwinheitzman commented May 3, 2025

Great change, thanks for picking this up 👍

christian-bromann
christian-bromann approved these changes May 3, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label May 3, 2025
@christian-bromann christian-bromann merged commit 5325db2 into webdriverio:main May 3, 2025
46 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented May 3, 2025

Hey Rondleysg 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@Rondleysg
Copy link
Member Author

Rondleysg commented May 3, 2025

Quick question, shouldn't we add this check to all public methods, like close() etc as well?

Yes, sorry, I should have added dismiss() too.
I'll do it in a new PR

@Rondleysg Rondleysg mentioned this pull request May 3, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Errors interacting with native browser dialogs (Bidi protocol)

4 participants

@Rondleysg @erwinheitzman @wdio-bot @christian-bromann