Skip to content

Fix avoid misleading BiDi connection failure message#14437

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
Rondleysg:main
Apr 30, 2025
Merged

Fix avoid misleading BiDi connection failure message#14437
christian-bromann merged 2 commits intowebdriverio:mainfrom
Rondleysg:main

Conversation

@Rondleysg
Copy link
Member

@Rondleysg Rondleysg commented Apr 30, 2025

Proposed changes

This pull request fixes the issue where WDIO always displays the error "ERROR webdriver: Could not connect to Bidi protocol of any candidate url in time" when trying to connect to BiDi. The change was suggested by tinklern to move the error log below the run and check for an undefined result. This issue was reported in #14430

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 30, 2025 •
edited
Loading

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14437

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14437

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14437

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14437

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14437

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14437

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14437

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14437

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14437

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14437

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14437

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14437

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14437

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14437

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14437

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14437

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14437

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14437

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14437

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14437

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14437

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14437

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14437

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14437

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14437

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14437

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14437

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14437

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14437

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14437

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14437

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14437

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14437

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14437

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14437

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14437

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14437

commit: db8633b

christian-bromann
christian-bromann requested changes Apr 30, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clear the timeout if the firstResolved actually resolves something.

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 30, 2025
christian-bromann
christian-bromann approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@christian-bromann christian-bromann merged commit 7c61373 into webdriverio:main Apr 30, 2025
46 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Apr 30, 2025

Hey Rondleysg 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@Delta456 Delta456 mentioned this pull request May 1, 2025
Closed
3 tasks
@dsufriawan
Copy link

dsufriawan commented May 6, 2025

Hi @christian-bromann, has this PR planned for a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rondleysg @wdio-bot @dsufriawan @christian-bromann