change gridProxyDetails request from GET to POST method#14431
Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom Apr 28, 2025
Merged
change gridProxyDetails request from GET to POST method#14431christian-bromann merged 1 commit intowebdriverio:mainfrom
christian-bromann merged 1 commit intowebdriverio:mainfrom
Conversation
The committers listed above are authorized under a signed CLA. |
Contributor
|
Hey ArtMathArt 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes a bug related to the browser.gridProxyDetails command:
You can see the issue reproduced in this GitHub Actions pipeline:
https://github.com/ArtMathArt/wdio-gridproxydetails-bug/actions/runs/14706091466/job/41266809797#step:8:101
or using the minimal reproducible example repository:
https://github.com/ArtMathArt/wdio-gridproxydetails-bug
The issue occurs because the undici library does not accept a body in GET requests, as explained here:
nodejs/undici#4013
Since Selenium Grid 3 also supports POST requests for this endpoint (selenium-grid2-api documentation),
I propose switching the request method from GET to POST.
The changes were tested and verified in the following GitHub Actions pipeline:
https://github.com/ArtMathArt/wdio-gridproxydetails-bug/actions/runs/14707097026/job/41270124569#step:11:92
In this pipeline, a custom version of wdio-protocols was built from my fork with the proposed updates and used for testing to confirm the fix.
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Thank you for reviewing this PR!
If any improvements or adjustments are needed, I'm happy to update it based on your feedback.
I'm excited to contribute to WebdriverIO and really appreciate your work maintaining this great project.
Reviewers: @webdriverio/project-committers