Add suite and test field of skipped test to xml report#14422
Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom Apr 22, 2025
Merged
Add suite and test field of skipped test to xml report#14422christian-bromann merged 2 commits intowebdriverio:mainfrom
christian-bromann merged 2 commits intowebdriverio:mainfrom
Conversation
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/cli
@wdio/concise-reporter
@wdio/browserstack-service
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
christian-bromann
requested changes
Apr 21, 2025
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Let's document this change.
| if (suiteKeys.length === 0) { | ||
| const error = this.runnerStat?.error ?? 'No tests found' | ||
| return builder.testCase().failure(error) | ||
| if (!isCucumberFrameworkRunner || (isCucumberFrameworkRunner && type === 'feature')) { |
Member
There was a problem hiding this comment.
Can you elaborate why we need this if statement? Maybe to help have contributors understand what this means, a comment may make sense here.
Contributor
Author
There was a problem hiding this comment.
Yeah, that is to make cucumber and mocha result look the same for empty suites. Otherwise, _buildOrderedReport will be ran twice for cucumber (for feature and scenario) and the xml will look like this:
<?xml version="1.0" encoding="UTF-8"?>
<testsuites tests="2" failures="2" errors="0" skipped="0">
<testsuite tests="1" failures="1" errors="0" skipped="0">
<testcase classname="" name="">
<failure message="No tests found"/>
</testcase>
</testsuite>
<testsuite tests="1" failures="1" errors="0" skipped="0">
<testcase classname="" name="">
<failure message="No tests found"/>
</testcase>
</testsuite>
</testsuites>which is ok too, if that's the look you want.
Member
There was a problem hiding this comment.
No, this makes total sense. Let's just add a comment help the next person understand this context because it is almost impossible to do so without this. Just add a comment with the appropriate context information.
Contributor
Author
Sure, how would you like me to document this? |
7f76c64 to
64bfe19
Compare
Contributor
Author
|
@christian-bromann better? |
Contributor
|
Hey ccharnkij 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
My attempt at addressing #14411 and #14374 while keeping #14223.
This is how it will look:
Tested with Jenkins Junit Plugin 1322.v1556dc1c59a_f
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers