Skip to content

fix(element): improve checkVisibility fallback handling in element.isDisplayed#14403

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
paymand:payman/checkVisibility
Apr 10, 2025
Merged

fix(element): improve checkVisibility fallback handling in element.isDisplayed#14403
christian-bromann merged 1 commit intowebdriverio:mainfrom
paymand:payman/checkVisibility

Conversation

@paymand
Copy link
Contributor

@paymand paymand commented Apr 10, 2025 •
edited
Loading

Proposed changes

Fix for #14316.

Background: I'm migrating to wdio v9 from v8 in order to migrate to Sauce Connect v5 from v4 and suddenly my tests have become super slow in Safari on iOS. I'm also getting these errors:

2025-04-10T21:37:50.569Z ERROR webdriver: WebDriverError: An unknown server-side error occurred while processing the command. Original error: elem.checkVisibility is not a function. (In 'elem.checkVisibility(params)', 'elem.checkVisibility' is undefined) when running "execute/sync" with method "POST" and args "function checkVisibility(elem, params) {

I'm running tests on Saucelabs (safari on iOS < 17.4) and they don't have support for newer iOS simulators yet (and I don't know when the support is coming either!):
https://saucelabs.com/products/supported-browsers-devices

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@paymand paymand mentioned this pull request Apr 10, 2025
Closed
3 tasks
@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 10, 2025

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14403

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14403

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14403

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14403

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14403

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14403

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14403

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14403

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14403

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14403

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14403

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14403

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14403

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14403

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14403

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14403

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14403

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14403

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14403

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14403

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14403

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14403

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14403

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14403

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14403

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14403

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14403

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14403

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14403

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14403

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14403

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14403

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14403

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14403

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14403

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14403

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14403

commit: 7ca6c79

christian-bromann
christian-bromann approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 10, 2025
@christian-bromann christian-bromann merged commit 4722443 into webdriverio:main Apr 10, 2025
45 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Apr 10, 2025

Hey paymand 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paymand @wdio-bot @christian-bromann