Skip to content

fix: unexpected token '?' on older browsers#14402

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
will-stone:main
Apr 10, 2025
Merged

fix: unexpected token '?' on older browsers#14402
christian-bromann merged 1 commit intowebdriverio:mainfrom
will-stone:main

Conversation

@will-stone
Copy link
Contributor

@will-stone will-stone commented Apr 10, 2025

Proposed changes

Fixes #14375

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@will-stone
Copy link
Contributor Author

will-stone commented Apr 10, 2025

So do I need to open another PR for v8?

@will-stone will-stone marked this pull request as ready for review April 10, 2025 20:26
@christian-bromann
Copy link
Member

christian-bromann commented Apr 10, 2025

So do I need to open another PR for v8?

Yes, please raise another PR against the v8 branch if you want to see this being backported.

christian-bromann
christian-bromann approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 10, 2025
@christian-bromann christian-bromann merged commit 8e9e320 into webdriverio:main Apr 10, 2025
6 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Apr 10, 2025

Hey will-stone 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
⚠️ You seemed to have committed using an email address ending up with @users.noreply.github.com, if you don't receive the email please feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 10, 2025

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14402

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14402

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14402

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14402

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14402

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14402

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14402

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14402

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14402

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14402

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14402

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14402

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14402

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14402

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14402

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14402

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14402

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14402

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14402

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14402

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14402

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14402

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14402

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14402

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14402

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14402

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14402

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14402

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14402

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14402

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14402

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14402

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14402

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14402

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14402

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14402

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14402

commit: 3893584

@will-stone
Copy link
Contributor Author

will-stone commented Apr 11, 2025

@christian-bromann Thanks, I'll do that now.

@will-stone will-stone mentioned this pull request Apr 11, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Use of nullish coalescing operator breaks compatibility with older browsers

3 participants

@will-stone @christian-bromann @wdio-bot