Skip to content

fix(utils): fix not to judged as screenshot the arg of switch*#14392

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
mato533:ta/fix-screenshot
Apr 10, 2025
Merged

fix(utils): fix not to judged as screenshot the arg of switch*#14392
christian-bromann merged 2 commits intowebdriverio:mainfrom
mato533:ta/fix-screenshot

Conversation

@mato533
Copy link
Member

@mato533 mato533 commented Apr 9, 2025

Proposed changes

When calling a command like:

browser.switchToWindow("9A562133B0552E0ECB7628F2E8A09E86")

You will see in the logs the following:

2025-04-09T02:30:59.864Z INFO webdriver: COMMAND switchToWindow("<Screenshot[base64]>")
2025-04-09T02:30:59.864Z INFO webdriver: [POST] http://localhost:55830/session/4d198ae401db65938c01497afabeb878/window
2025-04-09T02:30:59.864Z INFO webdriver: DATA { handle: '9A562133B0552E0ECB7628F2E8A09E86' }
2025-04-09T02:30:59.865Z INFO webdriver: RESULT null

The logs say that the switchToWindow parameter is a base64 screenshot.
Rather than fixing the fact that the command is judged as BASE64 itself, it would be more appropriate to exclude the command by checking.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 9, 2025 •
edited
Loading

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14392

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14392

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14392

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14392

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14392

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14392

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14392

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14392

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14392

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14392

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14392

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14392

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14392

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14392

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14392

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14392

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14392

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14392

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14392

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14392

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14392

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14392

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14392

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14392

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14392

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14392

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14392

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14392

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14392

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14392

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14392

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14392

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14392

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14392

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14392

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14392

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14392

commit: 1edb6d8

@mato533 mato533 changed the title fix(utils): fix not to judged as screenshot the arg of switchToWindow fix(utils): fix not to judged as screenshot the arg of switch* Apr 9, 2025
christian-bromann
christian-bromann approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Apr 10, 2025
@christian-bromann christian-bromann merged commit 990b0f0 into webdriverio:main Apr 10, 2025
46 checks passed
@mato533 mato533 deleted the ta/fix-screenshot branch April 10, 2025 15:11
@wdio-bot
Copy link
Contributor

wdio-bot commented Apr 10, 2025

Hey mato533 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $15 💸 PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mato533 @wdio-bot @christian-bromann