Skip to content

chore: ignore error handling for command wrapping#14383

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
sauravdas1997:accessibility-commannd-wrapping_v9
Apr 8, 2025
Merged

chore: ignore error handling for command wrapping#14383
christian-bromann merged 1 commit intowebdriverio:mainfrom
sauravdas1997:accessibility-commannd-wrapping_v9

Conversation

@sauravdas1997
Copy link
Contributor

@sauravdas1997 sauravdas1997 commented Apr 7, 2025 •
edited
Loading

Proposed changes

Handle failed tests when command is overwritten.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@sauravdas1997 sauravdas1997 requested a review from a team as a code owner April 7, 2025 11:56
@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 7, 2025

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14383

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14383

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14383

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14383

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14383

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14383

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14383

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14383

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14383

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14383

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14383

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14383

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14383

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14383

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14383

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14383

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14383

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14383

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14383

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14383

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14383

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14383

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14383

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14383

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14383

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14383

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14383

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14383

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14383

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14383

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14383

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14383

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14383

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14383

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14383

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14383

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14383

commit: 7dc2a45

@christian-bromann
Copy link
Member

christian-bromann commented Apr 7, 2025

@sauravdas1997 can you point to the issue that this PR fixes?

@sauravdas1997
Copy link
Contributor Author

sauravdas1997 commented Apr 8, 2025

Hey @christian-bromann the issue is in the browserstack-service. We are running accessibility scans before certain commands [code ref]. But in case when the selenium command fails, our error handler was catching the error but not re-throwing it. We handled the case in the PR.

Have handled

christian-bromann
christian-bromann approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Apr 8, 2025
@christian-bromann christian-bromann merged commit 834ae62 into webdriverio:main Apr 8, 2025
75 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sauravdas1997 @christian-bromann