Skip to content

feat(@wdio/protocols): Add "options" parameter to "terminateApp" command#14379

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
Nyaran:feature/support-terminateApp-options
Apr 6, 2025
Merged

feat(@wdio/protocols): Add "options" parameter to "terminateApp" command#14379
christian-bromann merged 2 commits intowebdriverio:mainfrom
Nyaran:feature/support-terminateApp-options

Conversation

@Nyaran
Copy link
Contributor

@Nyaran Nyaran commented Apr 5, 2025 •
edited
Loading

Fixes #14378

Proposed changes

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #14380

Further comments

Reviewers: @webdriverio/project-committers

@Nyaran Nyaran force-pushed the feature/support-terminateApp-options branch from 366f102 to d5f3cc0 Compare April 5, 2025 17:55
@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 5, 2025 •
edited
Loading

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14379

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14379

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14379

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14379

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14379

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14379

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14379

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14379

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14379

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14379

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14379

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14379

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14379

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14379

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14379

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14379

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14379

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14379

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14379

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14379

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14379

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14379

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14379

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14379

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14379

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14379

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14379

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14379

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14379

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14379

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14379

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14379

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14379

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14379

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14379

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14379

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14379

commit: a6fc025

@Nyaran Nyaran changed the title feat: Add "options" parameter to "terminateApp" command feat(protocols): Add "options" parameter to "terminateApp" command Apr 5, 2025
@Nyaran Nyaran changed the title feat(protocols): Add "options" parameter to "terminateApp" command feat(@wdio/protocols): Add "options" parameter to "terminateApp" command Apr 5, 2025
christian-bromann
christian-bromann reviewed Apr 5, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can

@Nyaran @christian-bromann
Apply suggestions from code review
a6fc025 
Co-authored-by: Christian Bromann <git@bromann.dev>
christian-bromann
christian-bromann approved these changes Apr 6, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Spec Compliancy 👓 PRs that contain changes to the protocol specs label Apr 6, 2025
@christian-bromann christian-bromann merged commit 263e717 into webdriverio:main Apr 6, 2025
43 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Apr 6, 2025

Hey Nyaran 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@Nyaran Nyaran deleted the feature/support-terminateApp-options branch April 8, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $15 💸 PR: Spec Compliancy 👓 PRs that contain changes to the protocol specs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Missing "options" parameter on terminateApp command

3 participants

@Nyaran @wdio-bot @christian-bromann