Skip to content

Bug Fix: missing Platform version on BrowserStack Observability#14280

Merged
christian-bromann merged 7 commits intowebdriverio:mainfrom
AdityaHirapara:v9_platform_version_fix
Mar 20, 2025
Merged

Bug Fix: missing Platform version on BrowserStack Observability#14280
christian-bromann merged 7 commits intowebdriverio:mainfrom
AdityaHirapara:v9_platform_version_fix

Conversation

@AdityaHirapara
Copy link
Contributor

@AdityaHirapara AdityaHirapara commented Mar 13, 2025 •
edited
Loading

Proposed changes

Fixes missing Platform version issue on BrowserStack Observability, in case of user not passing version

  • Get the platform version from driver caps in case of user is not passing it in capabilities.
  • Also keep a fallback on user's capability, for cases where the driver doesn't return the platform version.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #14300

Further comments

Reviewers: @webdriverio/project-committers

@AdityaHirapara AdityaHirapara requested a review from a team as a code owner March 13, 2025 11:42
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 13, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@christian-bromann
Copy link
Member

christian-bromann commented Mar 13, 2025

@AdityaHirapara let me know if you have any questions around signing the CLA

@AdityaHirapara AdityaHirapara mentioned this pull request Mar 18, 2025
Merged
13 tasks
@AdityaHirapara
Copy link
Contributor Author

AdityaHirapara commented Mar 18, 2025

@christian-bromann have signed the CLA, please review the changes.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 20, 2025 •
edited
Loading

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14280

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14280

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14280

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14280

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14280

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14280

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14280

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14280

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14280

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14280

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14280

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14280

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14280

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14280

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14280

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14280

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14280

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14280

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14280

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14280

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14280

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14280

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14280

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14280

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14280

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14280

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14280

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14280

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14280

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14280

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14280

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14280

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14280

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14280

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14280

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14280

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14280

commit: a770b92

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Mar 20, 2025
@christian-bromann christian-bromann merged commit 3bb6bda into webdriverio:main Mar 20, 2025
75 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdityaHirapara @christian-bromann @kamal-kaur04