Skip to content

fix: Combines exclude and wdio:exclude.#14236

Merged
christian-bromann merged 3 commits intowebdriverio:mainfrom
damencho:merge-excludes
Jun 19, 2025
Merged

fix: Combines exclude and wdio:exclude.#14236
christian-bromann merged 3 commits intowebdriverio:mainfrom
damencho:merge-excludes

Conversation

@damencho
Copy link
Contributor

@damencho damencho commented Feb 27, 2025

Proposed changes

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@damencho damencho mentioned this pull request Feb 27, 2025
Open
1 task
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 27, 2025 •
edited
Loading

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14236

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14236

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14236

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14236

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14236

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14236

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14236

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14236

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14236

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14236

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14236

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14236

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14236

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14236

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14236

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14236

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14236

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14236

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14236

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14236

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14236

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14236

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14236

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14236

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14236

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14236

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14236

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14236

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14236

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14236

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14236

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14236

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14236

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14236

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14236

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14236

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14236

commit: 80debe9

@erwinheitzman
Copy link
Member

erwinheitzman commented Mar 2, 2025

Hi could you explain why would we want this?

@damencho
Copy link
Contributor Author

damencho commented Mar 2, 2025

I have shared in the ticket why is that. And this comment also shows a simple sample where the current behavior is wrong
#13996 (comment)

@damencho
Copy link
Contributor Author

damencho commented Mar 13, 2025

@erwinheitzman any thoughts on this one?

@christian-bromann
Copy link
Member

christian-bromann commented Mar 13, 2025

@damencho fyi this is on my list of things to look at but haven't been able to do so just yet.

@damencho
Copy link
Contributor Author

damencho commented Mar 14, 2025

Thank you for the update :)

@damencho
Copy link
Contributor Author

damencho commented May 2, 2025

I hope this will not fall through the cracks :) Thanks.

@christian-bromann
Copy link
Member

christian-bromann commented May 2, 2025

It won't ;-) I think in 2 weeks I have some bandwith again to look into this.

@damencho
Copy link
Contributor Author

damencho commented May 2, 2025

Thanks. It is not urgent for us, but it prevents us from updating in the future ...

@damencho
Copy link
Contributor Author

damencho commented Jun 16, 2025

I don't think these failures are related to my changes, and they are passing on different macos versions.

@damencho
Copy link
Contributor Author

damencho commented Jun 19, 2025

@christian-bromann Did you have a chance to look at this? Thanks

christian-bromann
christian-bromann approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sorry for the delay here.

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jun 19, 2025
@christian-bromann christian-bromann merged commit c4f6eef into webdriverio:main Jun 19, 2025
41 of 43 checks passed
@christian-bromann
Copy link
Member

christian-bromann commented Jun 19, 2025

@damencho would you mind raising another PR with some additional docs better explaining the behavior?

@damencho
Copy link
Contributor Author

damencho commented Jun 19, 2025

@damencho would you mind raising another PR with some additional docs better explaining the behavior?

Where should the docs go?

@christian-bromann
Copy link
Member

christian-bromann commented Jun 19, 2025

I think here would make most sense.

@damencho damencho deleted the merge-excludes branch June 19, 2025 20:13
@damencho
Copy link
Contributor Author

damencho commented Jun 20, 2025

My proposal is #14578

@wdio-bot
Copy link
Contributor

wdio-bot commented Jun 20, 2025

Hey damencho 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@damencho
Copy link
Contributor Author

damencho commented Jun 21, 2025

@christian-bromann Will you be fixing the 9.16.0 npm release :)? Thank you

@damencho
Copy link
Contributor Author

damencho commented Jun 23, 2025

I saw the 9.16.0 thanks

@damencho
Copy link
Contributor Author

damencho commented Jun 24, 2025 •
edited
Loading

For the sake of completeness, I was able to drop the hack filtering specs when starting a worker (which was a slow process) by simply adding those excluded tests to the global exclude.
jitsi/jitsi-meet@bd612ef

@christian-bromann
Copy link
Member

christian-bromann commented Jun 24, 2025

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $35 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@damencho @erwinheitzman @christian-bromann @wdio-bot