[WDIO8] added supressing for runner's deleteSession#14166
Merged
christian-bromann merged 1 commit intov8from Feb 7, 2025
Merged
[WDIO8] added supressing for runner's deleteSession#14166christian-bromann merged 1 commit intov8from
christian-bromann merged 1 commit intov8from
Conversation
Contributor
|
Hey udarrr 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Until runner close worker, there is attempt to delete session in the end of worker's execution but if the session has been closed already for some reason whole execution is failed even though all tests are passed. I'd suggest to suppress delete session error as it's just finalizing step and don't relate to tests results
I'd suggest to change err.stack to err.message cause err.stack is redundant, there are lots of reference to internal libs no sure how it's helpful but looking like something important happened