Skip to content

[WDIO8] fixed empty process.execArgv#14150

Merged
christian-bromann merged 2 commits intov8from
fix/execArgv_v8
Feb 5, 2025
Merged

[WDIO8] fixed empty process.execArgv#14150
christian-bromann merged 2 commits intov8from
fix/execArgv_v8

Conversation

@udarrr
Copy link
Member

@udarrr udarrr commented Feb 5, 2025

Proposed changes

WDIO8

I've run into issue when accidentally, i don't know why there is no actions with the option, to array process.execArgv was assigned property 'forEachAsync' like [].forEachAsync that's why the loop is failed in process.execArgv[i] as 'for in' is iterating as with array' item as with array' properties

for (const i in process.execArgv) {
   const debugArgs = process.execArgv[i].match('--(debug|inspect)(?:-brk)?(?:=(.*):)?')
}

i've changed it to

for (const arg of process.execArgv) {
   const debugArgs = arg.match('--(debug|inspect)(?:-brk)?(?:=(.*):)?')
}

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Feb 5, 2025
@christian-bromann
Copy link
Member

@udarrr mind raising the same PR against the main branch too?

@christian-bromann christian-bromann merged commit b9eb478 into v8 Feb 5, 2025
10 of 11 checks passed
@christian-bromann christian-bromann deleted the fix/execArgv_v8 branch February 5, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants