feat(webdriverio): use checkVisibility for display checks#14075
Merged
christian-bromann merged 2 commits intomainfrom Jan 17, 2025
Merged
feat(webdriverio): use checkVisibility for display checks#14075christian-bromann merged 2 commits intomainfrom
christian-bromann merged 2 commits intomainfrom
Conversation
16 tasks
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/browser-runner
@wdio/appium-service
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
Member
|
Oh damn, nice that they standardised this! I can run some tests with this if we release a "next" version or something like this. What do you think? |
Member
Author
@erwinheitzman you can already via: npm i https://pkg.pr.new/webdriverio/webdriverio@14075 |
Member
|
@christian-bromann Great stuff! But I'm concerned about one thing: |
Member
Author
@nextlevelbeard can you raise a new issue for this? It seems unrelated to this change given we just change how we find out whether an element is visible. |
5ed8a4d to
b6c9bbb
Compare
b6c9bbb to
6ac6835
Compare
Closed
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The web platform now provides a
checkVisibilityfunction to verify if an element is visible or not. It makes sense to rely on that implementation than maintaining one (that we forked from a different project) ourselves.Furthermore this tweaks the function execution to expose the function name if available to make it easier to understand which WebdriverIO helper functions were called in the logs.
This "should" be a non breaking change but it is hard to say given that it is not much clear how the custom script worked.
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
n/a
Reviewers: @webdriverio/project-committers