Skip to content

fix(webdriverio): further polyfill improvements#14063

Merged
christian-bromann merged 1 commit intomainfrom
cb/polyfill-improvements
Jan 12, 2025
Merged

fix(webdriverio): further polyfill improvements#14063
christian-bromann merged 1 commit intomainfrom
cb/polyfill-improvements

Conversation

@christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Jan 12, 2025

Proposed changes

This patch adds further improvements to the polyfill manager. It now uses raw WebDriver Bidi commands and ensures in only registers the script on a top level frame as well as registered it in the context that actually got opened. Before it would run addInitScript which uses WebDriver Classic getWindowHandle which may be different. Also this patch ensures we only register it once.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 12, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 12, 2025

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14063

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14063

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14063

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14063

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14063

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14063

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14063

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14063

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14063

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14063

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14063

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14063

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14063

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14063

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14063

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14063

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14063

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14063

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14063

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14063

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14063

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14063

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14063

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14063

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14063

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14063

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14063

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14063

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14063

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14063

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14063

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14063

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14063

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14063

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14063

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14063

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14063

commit: 62d03d3

@christian-bromann christian-bromann merged commit 1e43606 into main Jan 12, 2025
@christian-bromann christian-bromann deleted the cb/polyfill-improvements branch January 12, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@christian-bromann