Skip to content

fix(@wdio/cli): initialize launcher also within watcher#14058

Merged
christian-bromann merged 2 commits intomainfrom
cb/init-launcher
Jan 10, 2025
Merged

fix(@wdio/cli): initialize launcher also within watcher#14058
christian-bromann merged 2 commits intomainfrom
cb/init-launcher

Conversation

@christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Jan 10, 2025

Proposed changes

Currently if you pass in a --watch flag within a TS project the WDIO cli fails with Unknown file extension ".ts" as TypeScript support wasn't enabled via tsx. We moved this before into the run method of the launcher, however the watcher class loads the config file before calling run.

This patch ensures we initialise the launcher before working with the config parser.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 10, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 10, 2025 •
edited
Loading

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14058

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14058

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14058

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14058

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14058

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14058

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14058

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14058

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14058

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14058

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14058

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14058

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14058

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14058

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14058

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14058

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14058

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14058

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14058

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14058

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14058

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14058

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14058

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14058

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14058

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14058

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14058

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14058

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14058

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14058

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14058

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14058

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14058

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14058

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14058

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14058

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14058

commit: 78fce4e

@christian-bromann christian-bromann merged commit a8ffac0 into main Jan 10, 2025
@christian-bromann christian-bromann deleted the cb/init-launcher branch January 10, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@christian-bromann