fix: Handle paths for accessibility#14054
Merged
christian-bromann merged 6 commits intowebdriverio:mainfrom Jan 28, 2025
Merged
fix: Handle paths for accessibility#14054christian-bromann merged 6 commits intowebdriverio:mainfrom
christian-bromann merged 6 commits intowebdriverio:mainfrom
Conversation
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/browser-runner
@wdio/browserstack-service
@wdio/appium-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
07souravkunda
approved these changes
Jan 10, 2025
christian-bromann
requested changes
Jan 10, 2025
| /* no-empty */ | ||
| } | ||
| } | ||
| return '' |
Member
There was a problem hiding this comment.
Shouldn't we throw an error here, it will otherwise fail with a weird error message when trying to create a write handle.
Contributor
Author
There was a problem hiding this comment.
we are doing path.join with the output. So this will not be an issue, since join function handles empty string.
| writableDir = accessibilityScripts.getWritableDir() | ||
| }) | ||
|
|
||
| it('should return a path when directory is present', () => { |
Member
There was a problem hiding this comment.
Let's enhance the test to actually verify that it walks through the list in case the first or second path is not existing.
Contributor
Author
There was a problem hiding this comment.
have added more test cases covering all the flows along with the loop
kamal-kaur04
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix: Handle writable path for accessibility commands
Types of changes
We are fixing an issue where we are not able to write to a certain path. Added a list of paths to try for writing some data.
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers