Skip to content

wdio: implement .entries() for ChainablePromiseArray#14024

Merged
christian-bromann merged 5 commits intowebdriverio:mainfrom
Delta456:array_entries
Jan 27, 2025
Merged

wdio: implement .entries() for ChainablePromiseArray#14024
christian-bromann merged 5 commits intowebdriverio:mainfrom
Delta456:array_entries

Conversation

@Delta456
Copy link
Contributor

@Delta456 Delta456 commented Jan 2, 2025

Proposed changes

Implements .entries() for ChainablePromiseArray so that index, value can be accessed from a for loop

for await (const [index, element] of await browser.$$('a').entries()) {
    console.log(await element.getText())
}

Closes #13954

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@Delta456 Delta456 changed the title wbdio: implement .entries() for ChainablePromiseArray wdio: implement .entries() for ChainablePromiseArray Jan 2, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 2, 2025 •
edited
Loading

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14024

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14024

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14024

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14024

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14024

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14024

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14024

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14024

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14024

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14024

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14024

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14024

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14024

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14024

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14024

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14024

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14024

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14024

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14024

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14024

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14024

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14024

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14024

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14024

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14024

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14024

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14024

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14024

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14024

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14024

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14024

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14024

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14024

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14024

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14024

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14024

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14024

commit: 6742b36

christian-bromann
christian-bromann requested changes Jan 2, 2025
View reviewed changes
christian-bromann
christian-bromann reviewed Jan 2, 2025
View reviewed changes
christian-bromann
christian-bromann approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Jan 27, 2025
@christian-bromann christian-bromann merged commit ec0f321 into webdriverio:main Jan 27, 2025
45 checks passed
@Delta456
Copy link
Contributor Author

Delta456 commented Jan 27, 2025

Thanks to @harsha509 for the major help with the implementation 🚀

@Delta456 Delta456 deleted the array_entries branch January 29, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[💡 Feature]: Support .entries() for ChainablePromiseArray

2 participants

@Delta456 @christian-bromann