fix: direction and scrollableElement error#14023
Merged
christian-bromann merged 2 commits intomainfrom Jan 2, 2025
Merged
Conversation
- update code and fix tests
wswebcreation
commented
Jan 2, 2025
Member
Author
wswebcreation
left a comment
There was a problem hiding this comment.
I'm trying to debug the "scrollableElement" malformed id error, but can't reproduce it. Still checking it
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
Member
Author
This doens't seem to be an issue, but the code of the user is. So stopping my investigation. PR is ready to review :D |
wswebcreation
commented
Jan 2, 2025
| // - left | ||
| // of the element. These positions will contain the x and y coordinates on where to put the finger | ||
| const { x, y, width, height } = await browser.getElementRect(scrollableElement?.elementId) | ||
| const { x, y, width, height } = await browser.getElementRect(await scrollableElement?.elementId) |
Member
Author
There was a problem hiding this comment.
Hmm, might this fix the error @Dinh246 was talking about? I first tested it on my machine with the old code and there was no issue. Then after running the adjusted appium-boilerplate code on GHA+Sauce I got the same error with the current webdriveriopackage, see https://github.com/webdriverio/appium-boilerplate/actions/runs/12587209761/job/35082582798#step:9:221
Member
Author
There was a problem hiding this comment.
Hmm, it might be, it's now also fails on iOS, see https://github.com/webdriverio/appium-boilerplate/actions/runs/12587209746/job/35082583004#step:7:254
This seems to be working on my machine due to the M3 and not on slower machines. So this fix might solve the issue
christian-bromann
approved these changes
Jan 2, 2025
Member
christian-bromann
left a comment
There was a problem hiding this comment.
This makes sense to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #14019
Proposed changes
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers