Skip to content

fix: Close appium server onComplete completly#14022

Merged
harsha509 merged 6 commits intowebdriverio:mainfrom
saikrishna321:fix-14017
Jan 3, 2025
Merged

fix: Close appium server onComplete completly#14022
harsha509 merged 6 commits intowebdriverio:mainfrom
saikrishna321:fix-14017

Conversation

@saikrishna321
Copy link
Contributor

@saikrishna321 saikrishna321 commented Jan 2, 2025

Proposed changes

Fixes: #14017
The new implementation provides a more robust process termination strategy:

  1. Makes onComplete async to properly handle promises
  2. Implements a multi-step kill process:
    • First attempts SIGTERM with proper promise handling
    • Falls back to SIGKILL if SIGTERM fails
    • As a last resort, attempts to kill the main process directly
  3. Adds comprehensive error handling and logging at each step

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@saikrishna321 @SrinivasanTarget
Close appium server onComplete completly
83ddc2f 
Co-authored-by: SrinivasanTarget <srinivasan.sekar1990@gmail.com>
christian-bromann
christian-bromann reviewed Jan 2, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, one comment.

saikrishna321 and others added 2 commits January 2, 2025 21:28
@saikrishna321 @SrinivasanTarget
fix review comments
9036281 
Co-authored-by: SrinivasanTarget <srinivasan.sekar1990@gmail.com>
@saikrishna321
Merge branch 'main' into fix-14017
3de97be
harsha509
harsha509 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 2, 2025 •
edited
Loading

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14022

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14022

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14022

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14022

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14022

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14022

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14022

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14022

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14022

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14022

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14022

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14022

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14022

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14022

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14022

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14022

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14022

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14022

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14022

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14022

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14022

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14022

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14022

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14022

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14022

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14022

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14022

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14022

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14022

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14022

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14022

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14022

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14022

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14022

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14022

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14022

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14022

commit: 6b99ada

christian-bromann
christian-bromann reviewed Jan 2, 2025
View reviewed changes
@saikrishna321 @SrinivasanTarget
Fix test
7b91f99 
Co-authored-by: SrinivasanTarget <srinivasan.sekar1990@gmail.com>
christian-bromann
christian-bromann reviewed Jan 2, 2025
View reviewed changes
@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Jan 2, 2025
saikrishna321 and others added 2 commits January 3, 2025 10:15
@saikrishna321 @SrinivasanTarget
Add comments back
b86bd5f 
Co-authored-by: SrinivasanTarget <srinivasan.sekar1990@gmail.com>
@harsha509
Merge branch 'main' into fix-14017
6b99ada
@harsha509
Copy link
Member

harsha509 commented Jan 3, 2025 •
edited
Loading

Merging as all review comments have been addressed and resolved.

Thank you @saikrishna321 🚀

@harsha509 harsha509 merged commit 0277db8 into webdriverio:main Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann left review comments

@harsha509 harsha509 harsha509 approved these changes

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Appium port is already be in use

3 participants

@saikrishna321 @harsha509 @christian-bromann