Skip to content

fix(webdriver): allow BiDiCore to send declared headers#14020

Merged
christian-bromann merged 3 commits intowebdriverio:mainfrom
navin772:send-headers-BiDiCore
Jan 2, 2025
Merged

fix(webdriver): allow BiDiCore to send declared headers#14020
christian-bromann merged 3 commits intowebdriverio:mainfrom
navin772:send-headers-BiDiCore

Conversation

@navin772
Copy link
Contributor

@navin772 navin772 commented Jan 2, 2025

Proposed changes

Fixes #13153

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 2, 2025 •
edited
Loading

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14020

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14020

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14020

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14020

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14020

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14020

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14020

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14020

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14020

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14020

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14020

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14020

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14020

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14020

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14020

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14020

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14020

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14020

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14020

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14020

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14020

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14020

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14020

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14020

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14020

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14020

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14020

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14020

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14020

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14020

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14020

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14020

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14020

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14020

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14020

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14020

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14020

commit: 5adb73c

erwinheitzman
erwinheitzman reviewed Jan 2, 2025
View reviewed changes
christian-bromann
christian-bromann approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Jan 2, 2025
@christian-bromann christian-bromann merged commit 94f0c0d into webdriverio:main Jan 2, 2025
@navin772 navin772 deleted the send-headers-BiDiCore branch January 2, 2025 16:01
@DudaGod DudaGod mentioned this pull request Feb 3, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwinheitzman erwinheitzman erwinheitzman left review comments

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: BidiCore does not send headers declared in wdio.conf.js on the upgrade GET request.

3 participants

@navin772 @christian-bromann @erwinheitzman