feat: add native mobile swipe by wswebcreation · Pull Request #14014 · webdriverio/webdriverio

wswebcreation · 2024-12-29T13:56:10Z

This PR adds a Mobile Native swipe command and contains the following

add new swipe for native apps method
add docs
update scrollIntoView to make it depended on the swipe
update UTs for scrollIntoView
update and fix formatter and template

Usage

it('should execute a default swipe', async () => {
    await browser.swipe();
});

it('should execute a swipe with options', async () => {
    await browser.swipe({
        direction: 'left',                  // Swipe from right to left
        duration: 5000,                     // Last for 5 seconds
        percent: 0.5,                       // Swipe 50% of the scrollableElement
        scrollableElement: $('~carousel'),  // The element to swipe within
    })
});

@todo: add UT's

Proposed changes

Types of changes

Polish (an improvement for an existing feature)
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update (improvements to the project's docs)
Specification changes (updates to WebDriver command specifications)
Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation (if appropriate)
I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

This change is solely for v9 and doesn't need to be back-ported
Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@todo

- add new swipe for native apps method - add docs - update `scrollIntoView` to make it depended on the `swipe` - update UTs for `scrollIntoView` - update and fix formatter and template @todo: add UT's

pkg-pr-new · 2024-12-29T13:58:57Z

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14014

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14014

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14014

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14014

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14014

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14014

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14014

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14014

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14014

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14014

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14014

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14014

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14014

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14014

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14014

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14014

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14014

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14014

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14014

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14014

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14014

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14014

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14014

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14014

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14014

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14014

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14014

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14014

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14014

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14014

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14014

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14014

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14014

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14014

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14014

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14014

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14014

commit: 96bd4e9

- add ut's - update docs

christian-bromann

I am very excited about this 🤩 some questions.

packages/webdriverio/src/commands/mobile/scrollIntoView.ts

packages/webdriverio/src/commands/mobile/swipe.ts

wswebcreation · 2024-12-30T17:29:57Z

I am very excited about this 🤩 some questions.

Thanks @christian-bromann , your feedback always makes my day!

I've now limited the swipe for native apps, but will think about a way for web and hybrid. The reason why that is different is related to the addresbar on Chrome and Safari for coordinate swipes. Same for hybrid apps where you don't know where the webview starts. That makes swiping on those apps complicated and flaky

christian-bromann

Awesome stuff 🙌

christian-bromann · 2024-12-30T17:44:13Z

removed the PR: Polish 💅 label now

This is ultimately a new feature. We can't label a PR with two labels at the moment :-/

feat: add native mobile swipe

f693f95

- add new swipe for native apps method - add docs - update `scrollIntoView` to make it depended on the `swipe` - update UTs for `scrollIntoView` - update and fix formatter and template @todo: add UT's

wswebcreation added PR: New Feature 🚀 PRs that contain new features PR: Polish 💅 PRs that contain improvements on existing features labels Dec 29, 2024

wswebcreation requested a review from christian-bromann December 29, 2024 13:56

wswebcreation added 3 commits December 30, 2024 09:24

feat: add duration

7e36165

- add ut's - update docs

chore: remove not used const

38b467d

Merge branch 'main' into ws/add-swipe

cdcf0b3

wswebcreation marked this pull request as ready for review December 30, 2024 09:01

wswebcreation added 2 commits December 30, 2024 12:30

chore: update docs

05b81c6

Merge branch 'main' into ws/add-swipe

8d3473b

christian-bromann reviewed Dec 30, 2024

View reviewed changes

packages/webdriverio/src/commands/mobile/scrollIntoView.ts Show resolved Hide resolved

packages/webdriverio/src/commands/mobile/swipe.ts Show resolved Hide resolved

chore: fixes after feedback

96bd4e9

christian-bromann approved these changes Dec 30, 2024

View reviewed changes

christian-bromann removed the PR: Polish 💅 PRs that contain improvements on existing features label Dec 30, 2024

christian-bromann merged commit ba09aeb into main Dec 30, 2024

christian-bromann deleted the ws/add-swipe branch December 30, 2024 17:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add native mobile swipe#14014

feat: add native mobile swipe#14014
christian-bromann merged 7 commits intomainfrom
ws/add-swipe

wswebcreation commented Dec 29, 2024 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Dec 29, 2024 •

edited

Loading

Uh oh!

christian-bromann left a comment

Uh oh!

Uh oh!

Uh oh!

wswebcreation commented Dec 30, 2024

Uh oh!

christian-bromann left a comment

Uh oh!

christian-bromann commented Dec 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

wswebcreation commented Dec 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Usage

Proposed changes

Types of changes

Checklist

Backport Request

Further comments

Reviewers: @webdriverio/project-committers

Uh oh!

pkg-pr-new bot commented Dec 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christian-bromann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wswebcreation commented Dec 30, 2024

Uh oh!

christian-bromann left a comment

Choose a reason for hiding this comment

Uh oh!

christian-bromann commented Dec 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wswebcreation commented Dec 29, 2024 •

edited

Loading

pkg-pr-new bot commented Dec 29, 2024 •

edited

Loading